robur
/
builder-web
5
0
Fork 0
Code Issues 20 Pull Requests 7 Releases Activity
Labels Milestones

Update to caqti 1.8.0 and dream 1.0.0~alpha4 #103

Merged
reynir merged 3 commits from caqti-dream-update into main 9 months ago
Conversation 2 Commits 3 Files Changed 34
reynir commented 10 months ago
Owner

This is work in progress. The changes for caqti 1.8.0 are mostly mechanical:

  • Open Caqti_request.Infix

  • Caqti_request.exec _ becomes _ ->. Caqti_type.unit,

  • Caqti_request.{find,find_opt,collect} _ _ becomes _ ->{!?*} _,

  • The above functions are deprecated in favor of the arrow functions in Caqti_request.Infix,

  • connect takes an optional argument ~tweaks_version defaulting to (1,7). Using (1,8) means foreign key constraints will be enabled for sqlite3.

  • Update to caqti 1.8.0

  • Update to dream 1.0.0~alpha4

  • Re-introduce nice not found error pages

This is work in progress. The changes for caqti 1.8.0 are mostly mechanical: - Open `Caqti_request.Infix` - `Caqti_request.exec _` becomes `_ ->. Caqti_type.unit`, - `Caqti_request.{find,find_opt,collect} _ _` becomes `_ ->{!?*} _`, - The above functions are deprecated in favor of the arrow functions in `Caqti_request.Infix`, - `connect` takes an optional argument `~tweaks_version` defaulting to (1,7). Using (1,8) means foreign key constraints will be enabled for sqlite3. - [x] Update to caqti 1.8.0 - [x] Update to dream 1.0.0~alpha4 - [ ] Re-introduce nice not found error pages
reynir added 1 commit 10 months ago
reynir added 1 commit 10 months ago
031c06eb33 Update to dream.1.0.0~alpha4
reynir force-pushed caqti-dream-update from 031c06eb33 to 702d38a6cc 10 months ago
reynir commented 10 months ago
Poster
Owner

Rebased on main. On branch dream-error-handler I pushed a not-great error handler implementation: fa1adb4d3f. From my perspective we would like to detect whether the not-found response is empty (as is the default in Dream) or if we have explicitly created the not-found response. It is not super obvious to me how to best accomplish this.

Rebased on main. On branch [dream-error-handler](https://git.robur.io/robur/builder-web/src/branch/dream-error-handler) I pushed a not-great error handler implementation: fa1adb4d3f3ce0141f977f404a99191d5ef9d2ec. From my perspective we would like to detect whether the not-found response is empty (as is the default in Dream) or if we have explicitly created the not-found response. It is not super obvious to me how to best accomplish this.
reynir changed title from WIP: Update to caqti 1.8.0 and dream 1.0.0~alpha4 to Update to caqti 1.8.0 and dream 1.0.0~alpha4 9 months ago
reynir merged commit a85be8730c into main 9 months ago
reynir commented 9 months ago
Poster
Owner

Merging this so it doesn't become too stale.

Merging this so it doesn't become too stale.
hannes deleted branch caqti-dream-update 9 months ago
The pull request has been merged as a85be8730c.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: robur/builder-web#103
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'caqti-dream-update'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes