Labels Milestones

Update to caqti 1.8.0 and dream 1.0.0~alpha4 #103

Merged

reynir merged 3 commits from caqti-dream-update into main 3 months ago

Conversation 2 Commits 3 Files Changed 34

reynir commented 4 months ago

Owner

This is work in progress. The changes for caqti 1.8.0 are mostly mechanical:

• Open Caqti_request.Infix

• Caqti_request.exec _ becomes _ ->. Caqti_type.unit,

• Caqti_request.{find,find_opt,collect} _ _ becomes _ ->{!?*} _,

• The above functions are deprecated in favor of the arrow functions in Caqti_request.Infix,

• connect takes an optional argument ~tweaks_version defaulting to (1,7). Using (1,8) means foreign key constraints will be enabled for sqlite3.

• Update to caqti 1.8.0

• Update to dream 1.0.0~alpha4

• Re-introduce nice not found error pages

This is work in progress. The changes for caqti 1.8.0 are mostly mechanical: - Open `Caqti_request.Infix` - `Caqti_request.exec _` becomes `_ ->. Caqti_type.unit`, - `Caqti_request.{find,find_opt,collect} _ _` becomes `_ ->{!?*} _`, - The above functions are deprecated in favor of the arrow functions in `Caqti_request.Infix`, - `connect` takes an optional argument `~tweaks_version` defaulting to (1,7). Using (1,8) means foreign key constraints will be enabled for sqlite3. - [x] Update to caqti 1.8.0 - [x] Update to dream 1.0.0~alpha4 - [ ] Re-introduce nice not found error pages

reynir added 1 commit 4 months ago

d3f583956e Update to caqti 1.8.0

reynir added 1 commit 4 months ago

031c06eb33 Update to dream.1.0.0~alpha4

- Dream.path is deprecated. For now the deprecation is suppressed.

- Remove unused dream_svg.

- Remove datadir global. The datadir variable is in scope already, and
  global variables were removed in alpha3.

- Dream_tar.tar_response: flush before closing. It's unclear if this is
  necessary.

- Change Builder_web.add_routes to Builder_web.routes returning a list
  of routes, and in Builder_web_app construct the router.

- Builder_web.not_found is removed due to changes in Dream.router. It
  seems an error handler might be the way forward.

reynir force-pushed caqti-dream-update from 031c06eb33 to 702d38a6cc 4 months ago

reynir commented 4 months ago

Poster

Owner

Rebased on main. On branch dream-error-handler I pushed a not-great error handler implementation: fa1adb4d3f. From my perspective we would like to detect whether the not-found response is empty (as is the default in Dream) or if we have explicitly created the not-found response. It is not super obvious to me how to best accomplish this.

Rebased on main. On branch [dream-error-handler](https://git.robur.io/robur/builder-web/src/branch/dream-error-handler) I pushed a not-great error handler implementation: fa1adb4d3f3ce0141f977f404a99191d5ef9d2ec. From my perspective we would like to detect whether the not-found response is empty (as is the default in Dream) or if we have explicitly created the not-found response. It is not super obvious to me how to best accomplish this.

reynir changed title from WIP: Update to caqti 1.8.0 and dream 1.0.0~alpha4 to Update to caqti 1.8.0 and dream 1.0.0~alpha4 3 months ago

reynir merged commit a85be8730c into main 3 months ago

reynir referenced this issue from a commit 3 months ago

Merge pull request 'Update to caqti 1.8.0 and dream 1.0.0~alpha4' (#103) from caqti-dream-update into main

reynir commented 3 months ago

Poster

Owner

Merging this so it doesn't become too stale.

Merging this so it doesn't become too stale.

reynir referenced this pull request 3 months ago

Nice error pages #108

hannes deleted branch caqti-dream-update 3 months ago

The pull request has been merged as a85be8730c.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.