Package visualization & repo scripts #123

Merged
reynir merged 2 commits from scripts-packaging into main 2 months ago
reynir commented 2 months ago
Owner

The repo scripts are installed in 'share' as examples.

I don't know how you mark files as config files if possible on FreeBSD.

The repo scripts are installed in 'share' as examples. I don't know how you mark files as config files if possible on FreeBSD.
reynir added 1 commit 2 months ago
303128e578 Package visualization & repo scripts
rand reviewed 2 months ago
mkdir -p "$sbindir" "$libexecdir" "$rcdir" "$sharedir" "$confdir/upload-hooks"
# stage service scripts
install -U "$pdir/rc.d/builder_web" "$rcdir/builder_web"
rand commented 2 months ago
Poster
Owner

Maybe not relevant for this PR, but this builder_web dir has an underscore instead of dash

Maybe not relevant for this PR, but this `builder_web` dir has an underscore instead of dash
Poster
Owner

Yes, using underscores in rc script names seems to be the norm on FreeBSD. I'll let @hannes decide if it should be changed (in a different PR/commit/issue).

Yes, using underscores in rc script names seems to be the norm on FreeBSD. I'll let @hannes decide if it should be changed (in a different PR/commit/issue).
rand requested changes 2 months ago
# stage visualization scripts
install -U "$bdir/packaging/batch-viz.sh" "$confdir/batch-viz.sh"
install -U "$bdir/packaging/visualization.sh" "$confdir/upload-hooks/visualization.sh"
rand commented 2 months ago
Poster
Owner

This should be named visualizations.sh (plural)

This should be named `visualizations.sh` (plural)
Poster
Owner

Thanks!

Thanks!
reynir marked this conversation as resolved
Owner

I think the builder-web parts of the paths are correct with the changes - thought I don't know much about the specific distro's directory-schemes. Looks good to me

I think the builder-web parts of the paths are correct with the changes - thought I don't know much about the specific distro's directory-schemes. Looks good to me
reynir added 1 commit 2 months ago
reynir merged commit 949dbab501 into main 2 months ago
reynir deleted branch scripts-packaging 2 months ago

Reviewers

rand requested changes 2 months ago
The pull request has been merged as 949dbab501.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.