Redirecting all unused suburls to parent suburl #81

Closed
rand wants to merge 7 commits from 20220208_redirecting_all_unused_suburls into 20220208_removing_trailing_slashes
rand commented 6 months ago
Owner

This is a nicety for certain users, including me - where one wants to be able to remove parts of an url structure, and then expect to get some sensible page in return. In other terms, it makes the url-tree be traversible towards the root, without there being "holes" returning "page not found".

This is a nicety for certain users, including me - where one wants to be able to remove parts of an url structure, and then expect to get some sensible page in return. In other terms, it makes the url-tree be traversible towards the root, without there being "holes" returning "page not found".
rand added 2 commits 6 months ago
reynir reviewed 6 months ago
let p = Dream.path req |> Utils.List.drop_last 1 |> String.concat "/" in
"/" ^ p
in
(*> goto brian on correct status here*)
Poster
Owner

What does this mean? :)

What does this mean? :)
rand commented 6 months ago
Poster
Owner

Hehe, my own note-language - should have written in normal language (; goto = todo, brian = brainstorm

Hehe, my own note-language - should have written in normal language (; goto = todo, brian = brainstorm
rand marked this conversation as resolved
rand added 1 commit 6 months ago
rand added 1 commit 6 months ago
rand added 1 commit 6 months ago
rand added 1 commit 6 months ago
hannes reviewed 6 months ago
Dream.get "/compare/:build_left/:build_right" (w compare_builds);
Dream.post "/upload" (Authorization.authenticate (w upload));
Dream.post "/job/:job/platform" redirect_to_parent;
Dream.post "/job/:job/platform/:platform" redirect_to_parent;
Poster
Owner

I don't think it is worth to have these POST redirects that lead a client to POST to /job/:job. The rest is fine with me.

I don't think it is worth to have these POST redirects that lead a client to POST to /job/:job. The rest is fine with me.
rand marked this conversation as resolved
rand added 1 commit 6 months ago
rand closed this pull request 4 months ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.