packaging/visualizations.sh: Made compatible with Linux too #99

Merged
rand merged 2 commits from 20220321_fixed_visualizations.sh_for_Linux into main 5 months ago
rand commented 5 months ago
Owner

What to do in the else branch? Fail or default to Linux?

What to do in the `else` branch? Fail or default to `Linux`?
rand added 1 commit 5 months ago
hannes reviewed 5 months ago
elif [ "$(uname)" = "FreeBSD" ]; then
mktemp -t "$1"
else
mktemp -t "$1.XXX" #< todo what to choose here
Poster
Owner

I'd be in favour to fail hard. "echo 'unsupported platform' ; exit 1"

I'd be in favour to fail hard. "echo 'unsupported platform' ; exit 1"
rand marked this conversation as resolved
hannes reviewed 5 months ago
elif [ "$(uname)" = "FreeBSD" ]; then
stat -f "%z" "$1"
else
stat -c "%s" "$1" #< todo what to choose here
Poster
Owner

again, fail hard.

again, fail hard.
rand marked this conversation as resolved
rand added 1 commit 5 months ago
rand merged commit c82e94805e into main 5 months ago
rand deleted branch 20220321_fixed_visualizations.sh_for_Linux 5 months ago
The pull request has been merged as c82e94805e.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.