robur
/
builder-web
5
0
Fork 0
Code Issues 20 Pull Requests 7 Releases Activity
Labels Milestones

packaging/visualizations.sh: Made compatible with Linux too #99

Merged
rand merged 2 commits from 20220321_fixed_visualizations.sh_for_Linux into main 10 months ago
Conversation 0 Commits 2 Files Changed 1
rand commented 11 months ago
Owner

What to do in the else branch? Fail or default to Linux?

What to do in the `else` branch? Fail or default to `Linux`?
rand added 1 commit 11 months ago
hannes reviewed 11 months ago
packaging/visualizations.sh Outdated
elif [ "$(uname)" = "FreeBSD" ]; then
mktemp -t "$1"
else
mktemp -t "$1.XXX" #< todo what to choose here
hannes commented 11 months ago
Owner

I'd be in favour to fail hard. "echo 'unsupported platform' ; exit 1"

I'd be in favour to fail hard. "echo 'unsupported platform' ; exit 1"
rand marked this conversation as resolved
hannes reviewed 11 months ago
packaging/visualizations.sh Outdated
elif [ "$(uname)" = "FreeBSD" ]; then
stat -f "%z" "$1"
else
stat -c "%s" "$1" #< todo what to choose here
hannes commented 11 months ago
Owner

again, fail hard.

again, fail hard.
rand marked this conversation as resolved
rand added 1 commit 11 months ago
rand merged commit c82e94805e into main 10 months ago
rand deleted branch 20220321_fixed_visualizations.sh_for_Linux 10 months ago
The pull request has been merged as c82e94805e.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: robur/builder-web#99
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '20220321_fixed_visualizations.sh_for_Linux'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes